lkml.org 
[lkml]   [2012]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -V4 04/10] memcg: Add HugeTLB extension
    (2012/03/19 15:52), Aneesh Kumar K.V wrote:

    > On Mon, 19 Mar 2012 11:38:38 +0900, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
    >> (2012/03/17 2:39), Aneesh Kumar K.V wrote:
    >>
    >>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
    >>>
    >>> This patch implements a memcg extension that allows us to control
    >>> HugeTLB allocations via memory controller.
    >>>
    >>
    >>
    >> If you write some details here, it will be helpful for review and
    >> seeing log after merge.
    >
    > Will add more info.
    >
    >>
    >>
    >>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
    >>> ---
    >>> include/linux/hugetlb.h | 1 +
    >>> include/linux/memcontrol.h | 42 +++++++++++++
    >>> init/Kconfig | 8 +++
    >>> mm/hugetlb.c | 2 +-
    >>> mm/memcontrol.c | 138 ++++++++++++++++++++++++++++++++++++++++++++
    >>> 5 files changed, 190 insertions(+), 1 deletions(-)
    >
    > ....
    >
    >>> +#ifdef CONFIG_MEM_RES_CTLR_HUGETLB
    >>> +static bool mem_cgroup_have_hugetlb_usage(struct mem_cgroup *memcg)
    >>> +{
    >>> + int idx;
    >>> + for (idx = 0; idx < hugetlb_max_hstate; idx++) {
    >>> + if (memcg->hugepage[idx].usage > 0)
    >>> + return 1;
    >>> + }
    >>> + return 0;
    >>> +}
    >>
    >>
    >> Please use res_counter_read_u64() rather than reading the value directly.
    >>
    >
    > The open-coded variant is mostly derived from mem_cgroup_force_empty. I
    > have updated the patch to use res_counter_read_u64.
    >

    Ah, ok. it's(maybe) my bad. I'll schedule a fix.


    Thanks,
    -Kame



    \
     
     \ /
      Last update: 2012-03-19 08:05    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site