Messages in this thread |  | | | Date | Mon, 19 Mar 2012 02:57:39 -0400 | | From | Christoph Hellwig <> | | Subject | Re: [PATCH 1/4] fs: Remove bogus wait in write_inode_now() |
| |
On Fri, Mar 09, 2012 at 10:02:25AM +0100, Jan Kara wrote: > inode_sync_wait() in write_inode_now() is just bogus. That function waits for > I_SYNC bit to be cleared but writeback_single_inode() clears the bit on return > so the wait is effectivelly a nop unless someone else submits the inode for > writeback again. All the waiting write_inode_now() needs is achieved by using > WB_SYNC_ALL writeback mode. > > Signed-off-by: Jan Kara <jack@suse.cz>
Loks good - I have the same in my patchkit to kill write_inode_now (which I really need to get out soon).
Signed-off-by: Christoph Hellwig <hch@lst.de>
|  |