lkml.org 
[lkml]   [2012]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] rtlwifi: Use is_zero_ether_addr, remove line continuation
    On 03/17/2012 02:13 PM, Joe Perches wrote:
    > Use the normal kernel facilities and use %pM
    > to print the all zero mac address.
    >
    > Remove unnecessary line continuation.
    >
    > Signed-off-by: Joe Perches<joe@perches.com>
    > ---
    > drivers/net/wireless/rtlwifi/cam.c | 5 ++---
    > 1 files changed, 2 insertions(+), 3 deletions(-)

    ACKed-by: Larry.Finger@lwfinger.net

    Is there a PATCH 2/2? I did not receive it.

    Larry

    >
    > diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
    > index 5c7d579..3d8cc4a 100644
    > --- a/drivers/net/wireless/rtlwifi/cam.c
    > +++ b/drivers/net/wireless/rtlwifi/cam.c
    > @@ -328,10 +328,9 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr)
    > RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG, "sta_addr is NULL\n");
    > }
    >
    > - if ((sta_addr[0]|sta_addr[1]|sta_addr[2]|sta_addr[3]|\
    > - sta_addr[4]|sta_addr[5]) == 0) {
    > + if (is_zero_ether_addr(sta_addr)) {
    > RT_TRACE(rtlpriv, COMP_SEC, DBG_EMERG,
    > - "sta_addr is 00:00:00:00:00:00\n");
    > + "sta_addr is %pM\n", sta_addr);
    > return;
    > }
    > /* Does STA already exist? */



    \
     
     \ /
      Last update: 2012-03-17 22:17    [W:0.024 / U:29.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site