lkml.org 
[lkml]   [2012]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] [media] staging: Return -EINTR in s2250_probe() if fails to get lock.
    Date
    Am Samstag, 17. März 2012, 17:00:36 schrieb santosh prasad nayak:
    > Oliver,
    >
    > The following changes are for review only not a formal patch.
    >
    > -------------------------------------------------------------------------------------------------------------
    > - if (mutex_lock_interruptible(&usb->i2c_lock) == 0) {
    > + mutex_lock(&usb->i2c_lock);
    > data = kzalloc(16, GFP_KERNEL);
    > - if (data != NULL) {
    > + if(data == NULL) {
    > + i2c_unregister_device(audio);
    > + kfree(state);
    > + return -ENOMEM;
    > + } else {
    > int rc;
    > rc = go7007_usb_vendor_request(go, 0x41, 0, 0,
    > data, 16, 1);
    > @@ -657,7 +661,7 @@ static int s2250_probe(struct i2c_client *client,
    > kfree(data);
    > }
    > mutex_unlock(&usb->i2c_lock);
    > - }
    > +
    >
    > ----------------------------------------------------------------------
    >
    >
    > Is it ok ?

    Hi,

    well done. That's correct.

    Regards
    Oliver
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-17 17:23    [W:0.023 / U:29.808 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site