lkml.org 
[lkml]   [2012]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 11/41] vfs: fix return value from do_last()
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Miklos Szeredi <mszeredi@suse.cz>

    commit 7f6c7e62fcc123e6bd9206da99a2163fe3facc31 upstream.

    complete_walk() returns either ECHILD or ESTALE. do_last() turns this into
    ECHILD unconditionally. If not in RCU mode, this error will reach userspace
    which is complete nonsense.

    Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/namei.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/namei.c
    +++ b/fs/namei.c
    @@ -2139,7 +2139,7 @@ static struct file *do_last(struct namei
    /* sayonara */
    error = complete_walk(nd);
    if (error)
    - return ERR_PTR(-ECHILD);
    + return ERR_PTR(error);

    error = -ENOTDIR;
    if (nd->flags & LOOKUP_DIRECTORY) {



    \
     
     \ /
      Last update: 2012-03-17 00:49    [W:0.036 / U:29.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site