lkml.org 
[lkml]   [2012]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] firmware loader: don't cancel _nowait requests when helper is not yet available
    On Fri, Mar 16, 2012 at 2:14 PM, Christian Lamparter
    <chunkeey@googlemail.com> wrote:
    >
    > Because As far as I know "driver_init();" is called before
    > "usermodehelper_enable();" in "do_basic_setup()".
    > So, theoretical these people should see the same WARNINGs
    > and read the comment about suspend/resume and I'm sure
    > they will be thinking: WTF!

    Just make the explanation be simple:

    "The system is not 8in a fully initialized state, and you cannot
    load firmware at this point. User mode is not running, not all devices
    have necessarily been initialized, user space applications may or may
    not be frozen, and the filesystem may or may not exist yet. Loading
    firmware is buggy under these circumstances. Go away"

    Don't try to go into any details. The "you can race with freezer" is
    too much detail. Even "suspend/resume" is too much detail. The fact
    is, the system just isn't ready yet. The details are almost entirely
    irrelevant, at best they can be examples of some things that can cause
    problems.

    Linus


    \
     
     \ /
      Last update: 2012-03-16 22:23    [W:0.021 / U:0.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site