lkml.org 
[lkml]   [2012]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] input: add driver support for MAX8997-haptic
On Fri, Mar 16, 2012 at 07:56:26PM +0100, Samuel Ortiz wrote:
> Hi Dmitry,
>
> On Fri, Mar 16, 2012 at 10:55:24AM -0700, Dmitry Torokhov wrote:
> > > > OK, excellent. I'll pick up this fix and apply the driver for 3.4 queue,
> > > > thanks!
> > > Your patch depends on the MFD changes Choi sent along the input driver. I
> > > think it would make more sense for me to take it. What do you think ?
> >
> > I think that splitting required platform data definitions from the
> > driver into separate patch is quite pointless.
> Hmm, you're right on this one.
>
> > I often see a driver
> > split in 3+ patches - headers, the driver itself and Kconfig/makefile
> > changes and I wonder what made them do it...
> >
> > Anyway, below is the consolidated patch I was going to apply to my tree,
> > but if you want to go through yours - feel free to apply it.
> No, I think it makes sense for you to take it. Add my:
> Acked-by: Samuel Ortiz <sameo@linux.intel.com>
>
> if you feel it's needed.

I will, thank you.

--
Dmitry


\
 
 \ /
  Last update: 2012-03-16 20:29    [W:0.087 / U:0.288 seconds]
©2003-2014 Jasper Spaans. Advertise on this site