Messages in this thread Patch in this message | | | Subject | RE: [PATCH] Fix the race between smp_call_function and CPU booting | From | Peter Zijlstra <> | Date | Fri, 16 Mar 2012 10:49:24 +0100 |
| |
On Fri, 2012-03-16 at 06:24 +0000, Liu, Chuansheng wrote:
> Based on your patch, I did a little modification, how do you think of that?
> --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -640,8 +640,10 @@ void set_cpu_present(unsigned int cpu, bool present) > > void set_cpu_online(unsigned int cpu, bool online) > { > - if (online) > + if (online) { > cpumask_set_cpu(cpu, to_cpumask(cpu_online_bits)); > + cpumask_set_cpu(cpu, to_cpumask(cpu_active_bits)); > + } > else > cpumask_clear_cpu(cpu, to_cpumask(cpu_online_bits)); > }
I'm thinking this lacks rationale. What was wrong, Why does this fix it. If you can't answer that stop tinkering and start thinking.
| |