lkml.org 
[lkml]   [2012]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] page_alloc: Remove argument to find_zone_movable_pfns_for_nodes
    From
    On Wed, Mar 14, 2012 at 4:12 PM, Kautuk Consul <consul.kautuk@gmail.com> wrote:
    > On Wed, Mar 14, 2012 at 2:17 AM, David Rientjes <rientjes@google.com> wrote:
    >> On Tue, 13 Mar 2012, Kautuk Consul wrote:
    >>
    >>> The find_zone_movable_pfns_for_nodes() function does not utiilize
    >>> the argument to it.
    >>>
    >>
    >> It could, though, if we made it to do so.
    >>
    >>> Removing this argument from the function prototype as well as its
    >>> caller, i.e. free_area_init_nodes().
    >>>
    >>
    >> Not sure if we'd ever want it or not for other purposes, but
    >> find_zone_movable_pfns_for_nodes() could easily be made to use the passed
    >> in array rather than zone_movable_pfn in file scope directly.  That seems
    >> to be why it took an argument in the first place.
    >>
    >
    > No function is calling this function and I just wanted to remove the
    > slight overhead of passing an
    > argument which does not get used.

    Sorry.. I meant : no other function oter than free_area_init_nodes()
    calls this function.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-14 11:47    [W:0.024 / U:61.240 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site