lkml.org 
[lkml]   [2012]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Install kernel-page-flags.h
On 03/14/2012 03:58 AM, Christoph Hellwig wrote:
> I don't think this is a good idea at all. Let's shoot the person who
> added that braindead interface ASAP, and replace it with one printing
> the flags in ASCII format.

This isn't really realistic. The information is retrieved based on the
PFN using lseek+read from a file descriptor. How is the read supposed
to work in case the record returned is not of a fixed size? Aside,
potentially a lot of these records are to be read and using ASCII
strings will significantly slow things down.

If you have a concrete proposal please go ahead and propose it.


\
 
 \ /
  Last update: 2012-03-14 10:47    [from the cache]
©2003-2011 Jasper Spaans