lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/5] printk: use alloc_bootmem() instead of memblock_alloc().
> that seems not right.
>
> for x86, setup_log_buf(1) is quite early called in setup_arch() before
> bootmem is there.
>
> bootmem should be killed after memblock is supported for arch that
> current support bootmem.

Hmm. x86 uses nobootmem.c, which implements bootmem in terms of
memblock anyway. It is definitely working at setup_log_buf() time (or
else it wouldn't be able to select a sensible buffer location).

I suppose you're saying that it wouldn't work for a hypothetical
architecture that *does* support bootmem and *also* supports
setup_log_buf(1). Will there ever be such an architecture, or will
bootmem be retired first?

Thanks,

Avery


\
 
 \ /
  Last update: 2012-03-13 07:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site