Messages in this thread |  | | | From | Grant Likely <> | | Subject | RE: [PATCH 1/2] gpio/davinci: fix oops on unbanked gpio irq request | | Date | Mon, 12 Mar 2012 22:39:30 -0600 |
| |
On Mon, 12 Mar 2012 18:54:53 +0000, "Nori, Sekhar" <nsekhar@ti.com> wrote: > Hi Grant, > On Mon, Mar 12, 2012 at 23:21:35, Grant Likely wrote: > > On Sun, 11 Mar 2012 18:16:11 +0530, Sekhar Nori <nsekhar@ti.com> wrote: > > > Unbanked GPIO irq setup code was overwriting chip_data leading > > > to the following oops on request_irq() > > > > > > Unable to handle kernel paging request at virtual address febfffff > > [...] > > > Fix the issue. > > > > Applied, but for next time "Fix the issue" isn't the most helpful commit text. > > Please describe *how* you fixed the issue so that future commit readers have > > more clues as to what this patch is doing. > > Thanks for the feedback and noted for future. If it's not too much trouble, > can you change the last line in commit message to: > > Fix the issue by making unbanked GPIO code not overwrite chip_data because > generic irq chip code uses it for its data structures. Instead use > handler_data to pass around GPIO controller information.
I've already pushed it out, so I cannot rebase it, but thanks for taking me seriously. :-D
g.
|  |