lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: rtl8187se: r8180_core.c: Fix coding style issue
On 03/13/2012 09:46 PM, Joe Perches wrote:
> On Tue, 2012-03-13 at 22:33 -0400, Andrew Miller wrote:
>> Thanks, you help me alot
>>
>> If you don't mind me asking a few more question.
>>
>> Would fixing things like this
>>
>> - if(x==y)
>> + if(x == y)
>>
>> be worthless?
>
> I don't work on staging code.
>
> I believe the staging rtl8187se directory could be
> deleted as there is a working mainline directory
> for the 8187 (drivers/net/wireless/rtl818x/rtl8187)
> so you may not actually be adding anything of value.
>
> I don't know if the 8187se is supported by the 8187
> code but likely Larry Finger (cc'd) knows better.

Driver rtl8187 handles USB devices - the RTL8187SE is PCI based - thus separate
drivers are needed. I have done a lot of the conversion of a mac80211-based
driver for the RTL8187SE, but ran into a problem where it could transmit small
packets, but fail completely for longer ones. While trying to fix that, I needed
to work on devices that had no Linux driver, and I have not gotten back to it.

Larry



\
 
 \ /
  Last update: 2012-03-14 04:13    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site