Messages in this thread | | | Subject | Re: [PATCH] checkpatch: Suggest pr_<level> over printk(KERN_<LEVEL> | From | Joe Perches <> | Date | Tue, 13 Mar 2012 20:01:14 -0700 |
| |
On Tue, 2012-03-13 at 22:41 -0400, Ted Ts'o wrote: > On Tue, Mar 13, 2012 at 07:31:51PM -0700, Joe Perches wrote: > > Right now many fs ext4 messages are somewhat opaque > > without any reference to what kernel subsystem produced > > the message. > > > > For instance: > > > > fs/ext4/ialloc.c: printk(KERN_DEBUG "group %lu: stored = %d, counted = %lu\n", > > > > This is a somewhat senseless output in dmesg without > > any linkage to ext4. > > > > Using pr_fmt and pr_debug as I sent a patch to do > > instead emits in dmesg: > > > > EXT4-fs: group: etc... > > > > Using subsystem prefixes makes it easy and consistent to > > grep dmesg. > > That's a debug message which is never by anyone other than ext4 > developers. Your patch also hacked the Makefile to enable it by > default,
It's just an example and no it didn't. That output is still in an #ifdef EXT4FS_DEBUG block and is unchanged.
What I did was #define DEBUG so pr_debug (and so dynamic_debug if desired as well) emits output to dmesg.
+ccflags-$(CONFIG_EXT4_FS) := -DDEBUG
ext4 doesn't currently use any #ifdef DEBUG blocks.
> which also enabled some performance degrading code paths > (again, only enabled by developers who manually drop the #define in a > header file when they are trying to figure out some obscure failure > during the development process). This is why I don't like people who > are wanking around in code they don't understand just to fix style > fixes, in the mistaken belief that it adds value.
cheers, Joe
| |