lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: rtl8187se: r8180_core.c: Fix coding style issue
On Tue, Mar 13, 2012 at 10:33:42PM -0400, Andrew Miller wrote:
> Thanks, you help me alot
>
> If you don't mind me asking a few more question.
>
> Would fixing things like this
>
> - if(x==y)
> + if(x == y)
>
> be worthless?

Yes, as it should really be:
if (x == y)
:)

> Changing c++ style comment to c style?

That's also good.

> And I should not wory about line being longer the 80 charactor, unless they are
> just extremely long?

If you feel it will read better, than yes, do it.

> I'm just over half way through my CS degree, so I'm a complete noob.
> I'm still learning what is not worth spending time on and what is.

This is worthwhile, if you want to do this. Cleanups like this are a
great place to learn and get involved and become comfortable with the
codebase.

Just don't mix different fixes in the same patch.

And don't top post :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-03-14 03:57    [W:1.314 / U:0.084 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site