lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch: Suggest pr_<level> over printk(KERN_<LEVEL>
On Tue, Mar 13, 2012 at 05:47:06PM -0700, Joe Perches wrote:
> Or add an I: line to MAINTAINERS
>
> though perhaps it's better to agree on a style.
>
> I did send a few fixes and a style consolidation patch
> for ext4 with no reply awhile ago:
>
> https://lkml.org/lkml/2011/8/2/41

You combined a huge number of changes into a single patch, and as far
as I was concerned the value it added Just Wasn't Worth It. It adds
noise which causes other patches, which add real value, not to apply
cleanly.

I routinely ignore such patches because I have a limited amount of
time, and as far as I'm concerned they mainly make my life harder.

Looking more closely, there are a few changes in there that I'd
accept, but it was burried amongst so much other junk that if it's all
or nothing, it would be nothing. Funny that someone who is an expert
in style things neglected something **far** more important ---
segregate logical changes in separate commits; don't collapse
everything into a single patch, which makes it hard to review.

- Ted


\
 
 \ /
  Last update: 2012-03-14 02:09    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site