Messages in this thread | | | Subject | Re: [PATCH] checkpatch: Suggest pr_<level> over printk(KERN_<LEVEL> | From | Joe Perches <> | Date | Tue, 13 Mar 2012 17:47:06 -0700 |
| |
On Tue, 2012-03-13 at 20:31 -0400, Ted Ts'o wrote: > On Tue, Mar 13, 2012 at 03:03:16PM -0700, Andrew Morton wrote: > > > Sure but if a particular kernel file or subsystem is _not_ using > > > pr_foo(), having a checkpatch which tries to force everyone to use > > > pr_foo() is going to be really annoying to me as a maintainer... > > > > Yes, that's what I fear. That's why I'm testing it... > > Perhaps the answer is a ".checkpatch_ignore" file that can be > maintained by maintainers in each directory to suppress specific > checkpatch warnings that the maintainers don't agree with. That way > we don't have to worry about checkpatch maintainers try to impose > their pet programming style preferences on maintainers who don't want > to get random trivial style-fixing patches from well-meaning kernel > newbies...
Or add an I: line to MAINTAINERS
though perhaps it's better to agree on a style.
I did send a few fixes and a style consolidation patch for ext4 with no reply awhile ago:
https://lkml.org/lkml/2011/8/2/41
| |