Messages in this thread |  | | | From | Kay Sievers <> | | Date | Wed, 14 Mar 2012 01:14:35 +0100 | | Subject | Re: [PATCH] firmware loader: don't cancel _nowait requests when helper is not yet available |
| |
On Wed, Mar 14, 2012 at 01:10, Rafael J. Wysocki <rjw@sisk.pl> wrote: > On Wednesday, March 14, 2012, Kay Sievers wrote:
>> It is relevant in the sense that the firmware loader should not even >> know that a uevent *can* cause a usermodehelper exec() if it runs in >> legacy mode. The firmware loader just has no business in fiddling with >> the details of driver core legacy stuff. I don't think his warning >> makes much sense. > > But that warning actually triggers for drivers that attempt to use > request_firmware() during system resume, even though /sbin/hotplug isn't > used any more. > > usermodehelper_is_disabled() means "we are in the middle of system power > transition" rather than anything else (I agree it should be called > suspend_in_progress() or something similar these days).
Yeah it's certainly useful to disable the exec() during suspend calls, much more than using the exec() inhibit flag for the firmware loader to throw a warning about suspend issues.
Such confusing hacks need at least a comment, that makes this very obvious. :)
Kay
|  |