Messages in this thread | | | Subject | Re: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg | From | Joe Perches <> | Date | Tue, 13 Mar 2012 09:34:55 -0700 |
| |
On Tue, 2012-03-13 at 14:39 +0200, Artem Bityutskiy wrote: > On Mon, 2012-03-12 at 10:11 -0700, Joe Perches wrote: > > On Mon, 2012-03-12 at 18:35 +0200, Artem Bityutskiy wrote: > > > On Mon, 2012-03-12 at 08:33 -0700, Joe Perches wrote: > > > > I tentatively converted them to a bitmap > > > > and a single jffs2_dbg(mask, fmt, ...) > > > > but perhaps all of these could be deleted > > > > too. > > > I think it is better to convert them to jffs2_debug(). And I guess after > > > the change the "mask" parameter will go away? > > Mask would remain and perhaps become a module > > variable instead of a compile #define. > > What is jffs2_debug? > Sorry, I meant to suggest to just turn them all to jffs2_dbg() which you > introduced, without any bitmasks.
These functions are conditionally compiled today.
Introducing a bitmask allows the same conditional compilation optimization.
David? as nominal maintainer, do you have an opinion?
btw: Artem, you are not listed in the MAINTAINERS entry for jffs2. Should you be?
| |