lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/5] ARM: imx28: add basic dt support
On 03/13/2012 09:35 AM, Rob Herring wrote:
> + ahb@80080000 {
> + fec@800f0000 {
> Use generic names: ethernet@800f0000
Generic is good, but consistency is better, IMHO. grepping existing dts
files in 3.2.9 finds 6 instances of "fec@" and 0 instances of "ethernet@"
>> + uart1: uart@80074000 {
> Use generic names: uart1: serial@...
Same comment here, but unfortunately there is already inconsistency in
existing files... 25 instances of "serial@" and 35 instances of "uart@"



\
 
 \ /
  Last update: 2012-03-13 16:07    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site