lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] dma: imx-sdma: Treat firmware messages as warnings instead of erros
    On Thu, Mar 08, 2012 at 09:26:39AM -0300, Fabio Estevam wrote:
    > As the SDMA controller can operate without an external firmware being loaded,
    > treat the firmware related messages as warnings rather than errors.
    >
    > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

    Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

    Sascha

    > ---
    > drivers/dma/imx-sdma.c | 6 +++---
    > 1 files changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
    > index c495882..3b7ebd4 100644
    > --- a/drivers/dma/imx-sdma.c
    > +++ b/drivers/dma/imx-sdma.c
    > @@ -1389,7 +1389,7 @@ static int __init sdma_probe(struct platform_device *pdev)
    > if (pdata) {
    > ret = sdma_get_firmware(sdma, pdata->fw_name);
    > if (ret)
    > - dev_err(&pdev->dev, "failed to get firmware from platform data\n");
    > + dev_warn(&pdev->dev, "failed to get firmware from platform data\n");
    > } else {
    > /*
    > * Because that device tree does not encode ROM script address,
    > @@ -1399,11 +1399,11 @@ static int __init sdma_probe(struct platform_device *pdev)
    > ret = of_property_read_string(np, "fsl,sdma-ram-script-name",
    > &fw_name);
    > if (ret)
    > - dev_err(&pdev->dev, "failed to get firmware name\n");
    > + dev_warn(&pdev->dev, "failed to get firmware name\n");
    > else {
    > ret = sdma_get_firmware(sdma, fw_name);
    > if (ret)
    > - dev_err(&pdev->dev, "failed to get firmware from device tree\n");
    > + dev_warn(&pdev->dev, "failed to get firmware from device tree\n");
    > }
    > }
    >
    > --
    > 1.7.1
    >
    >
    >

    --
    Pengutronix e.K. | |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
    Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |


    \
     
     \ /
      Last update: 2012-03-13 14:15    [W:0.026 / U:0.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site