| | From | Miklos Szeredi <> | | Subject | Re: [PATCH 05/25] vfs: add filesystem flags for atomic_open | | Date | Tue, 13 Mar 2012 12:17:08 +0100 |
| |
Christoph Hellwig <hch@infradead.org> writes:
> On Wed, Mar 07, 2012 at 10:22:22PM +0100, Miklos Szeredi wrote: >> From: Miklos Szeredi <mszeredi@suse.cz> >> >> Allow filesystem to select which cases it wants to perform atomic_open. > > Given that atomic_open is allowed to return a NULL filp and fall back to > the traditional open I don't think this is needed - it can be much > cleaner handled by the fs just returning NULL for that case.
Hmm, yeah. The reason I did this was to prevent doing permission/ security checks twice before create.
But in fact that could be optimized away with careful code flow. I'll look into dropping this.
Thanks, Miklos
|