lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] uprobes/core: handle breakpoint and signal step exception.

    * Srikar Dronamraju <srikar@linux.vnet.ibm.com> wrote:

    > * Ingo Molnar <mingo@elte.hu> [2012-03-13 06:47:44]:
    >
    > >
    > > * Ingo Molnar <mingo@elte.hu> wrote:
    > >
    > > > To make it available to uprobes please move is_ia32_task() to
    > > > processor.h and make it return 1 on i386 kernels. This should
    > > > be a very simple patch - and that's all that is needed.
    > >
    > > Side note: in general I don't mind making compat.h a bit more
    > > generic (at all), but is_ia32_task() is really a generic x86
    > > specific check that we can move to processor.h cleanly.
    > >
    > > Some other effort should make compat.h bitness agnostic -
    > > uprobes doesn't actually make use of the compat types and
    > > facilities there, and it resulted in a nonsensical change like
    > > making the alloc function generic ...
    > >
    >
    > Okay, Will move is_ia32_task() to processor.h and use it.

    thread_info.h might be a better place, because the TIF_ flags
    are defined there.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2012-03-13 10:41    [W:0.023 / U:0.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site