Messages in this thread | | | Date | Mon, 12 Mar 2012 17:06:23 +0900 | Subject | Re: [PATCH v6 1/5] Extcon (external connector): import Android's switch class and modify. | From | MyungJoo Ham <> |
| |
On Fri, Mar 9, 2012 at 9:41 PM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Mon, Feb 27, 2012 at 09:15:35PM +0900, MyungJoo Ham wrote: > >> +#ifdef CONFIG_ANDROID >> + extcon_class = class_create(THIS_MODULE, "switch"); >> +#else /* !CONFIG_ANDROID */ >> + extcon_class = class_create(THIS_MODULE, "extcon"); >> +#endif /* CONFIG_ANDROID */ > > This seems somewhat sad - if ANDROID is turned on the standard ABI > vanishes. It'd be much nicer to do this with a symlink (or with > symlinks within the android directory if the driver core doesn't support > that). That way userspace code can be written to the new ABI and will > work on Android systems without ifdefery.
Yes, this was the itching part.
I'll first look into creating symlinks (either /sys/class/switch --> /sys/class/extcon or /sys/class/switch/* --> /sys/class/extcon/*). However, I think this symbolic links are better created selectively w/ CONFIG_ANDROID.
Thanks.
Cheers! MyungJoo.
-- MyungJoo Ham, Ph.D. Mobile Software Platform Lab, DMC Business, Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |