lkml.org 
[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: simple_strtoull() - FIXME?
    On 13/03/12 03:16, Shuah Khan wrote:

    > What's this FIXME in simple_strtoull() for? Something to be terribly
    > concerned about and need fixing (assuming there is something that still
    > needs fixing)
    >
    > unsigned long long simple_strtoull(const char *cp, char **endp, unsigned
    > int base)
    > {
    > unsigned long long result;
    > unsigned int rv;
    >
    > cp = _parse_integer_fixup_radix(cp, &base);
    > rv = _parse_integer(cp, base, &result);
    > /* FIXME */


    git blame/show answers your question. From the commit message of
    1dff46d6: lib/kstrtox: common code between kstrto*() and simple_strto*()
    functions:

    simple_strtoull() (and scanf(), BTW) ignores integer overflow, that's a
    bug we currently don't have guts to fix, making KSTRTOX_OVERFLOW hack
    necessary.

    Note that simple_strtoull and friends are now deprecated (see
    include/linux/kernel.h) and you should now be using the kstrto*
    functions instead.

    ~Ryan



    \
     
     \ /
      Last update: 2012-03-13 00:21    [W:0.021 / U:3.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site