lkml.org 
[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg
    From
    Date
    On Mon, 2012-03-12 at 15:12 +0200, Artem Bityutskiy wrote:
    > On Fri, 2012-03-09 at 10:49 -0800, Joe Perches wrote:
    > > On Fri, 2012-03-09 at 13:53 +0200, Artem Bityutskiy wrote:
    > > > OK, pushed these ones, although I think that mechanical D1->jffs2_dbg()
    > > > conversion is not very useful and to make your patch-set worth the
    > > > trouble you should do few more clean-up steps, like I suggested.
    > >
    > > Do you want me to remove the D2/jffs2_dbg(2, ...) instances
    > > or just eliminate the first arg to jffs2_dbg and keep the
    > > current jffs2_dbg(2,...) instances?
    >
    > Just remove. There were few other suggestions as well :-)

    what about all the dbg_<foo> calls like
    dbg_readinode(fmt, ...)?

    I tentatively converted them to a bitmap
    and a single jffs2_dbg(mask, fmt, ...)
    but perhaps all of these could be deleted
    too.





    \
     
     \ /
      Last update: 2012-03-12 16:35    [W:0.037 / U:91.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site