[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [ 02/12] Remove COMPAT_IA32 support
    On Mon, 2012-03-12 at 07:30 +0100, Willy Tarreau wrote:
    > On Sun, Mar 11, 2012 at 07:49:48PM -0700, Greg KH wrote:
    > > On Mon, Mar 12, 2012 at 01:07:26AM +0000, Ben Hutchings wrote:
    > > > On Mon, 2012-03-12 at 01:20 +0100, Willy Tarreau wrote:
    > > > > 2.6.32-longterm review patch. If anyone has any objections, please let me know.
    > > >
    > > > The subject/first line should include '[IA64]', as in the original
    > > > commit. It looks like this has been automatically stripped.
    > >
    > > Yeah, munging patches to and from quilt and git will cause that to
    > > happen at times, it's quite common :(
    > Indeed, and I've even changed my patch formats in haproxy to avoid brackets
    > due to this issue. The cause is that many patches are sent with a [PATCH]
    > prefix and that with Git, either you keep the subject line intact or you
    > remove everything that is between brackets. There's the -b option to only
    > remove remove tags looking like [PATCH], but my general experience with it
    > was not satisfying (I don't remind why). I have added some scripts to do
    > this at some points in the process but it's not 100% reliable as can be
    > seen here.
    > The "funny" thing here is that this comment lacking any IA64 tag annoyed
    > me a bit, and I was about to change its name then refrained from doing
    > so because I prefered not to keep the original message intact as I did
    > not notice the tag went off on my side :-/
    > Ben, I strongly suggest that you too switch your practise from "[IA64]"
    > to "IA64:" as can be seen on many kernel commits these days.

    That is my personal practice. But I copied this subject from the
    mainline commit.


    Ben Hutchings
    Life would be so much easier if we could look at the source code.
    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2012-03-12 16:27    [W:0.030 / U:3.960 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site