lkml.org 
[lkml]   [2012]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] Video : Amba: Use in_interrupt() in clcdfb_sleep().
    From
    On Sun, Mar 11, 2012 at 2:14 PM, santosh nayak
    <santoshprasadnayak@gmail.com> wrote:
    > From: Santosh Nayak <santoshprasadnayak@gmail.com>
    >
    > Instead of "in_atomic()", we can use in_interrupt() to check whether
    > its an interrupt context.

    What is the benefit?

    Your change turns clcdfb_sleep() into a ticking bomb.
    If clcdfb_sleep() is called from an atomic section (e.g. under a
    spinlock) it will call msleep()
    and the whole thing explodes...

    --
    Thanks,
    //richard


    \
     
     \ /
      Last update: 2012-03-11 14:25    [W:0.050 / U:0.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site