lkml.org 
[lkml]   [2012]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/4] Drivers: hv: Support the newly introduced KVP messages in the driver
    On Sat, Mar 10, 2012 at 03:32:09PM -0800, K. Y. Srinivasan wrote:
    > + switch (message->kvp_hdr.operation) {
    > + case KVP_OP_SET:
    > + switch (in_msg->body.kvp_set.data.value_type) {
    > + case REG_SZ:
    > + /*
    > + * The value is a string - utf16 encoding.
    > + */
    > + message->body.kvp_set.data.value_size =
    > + utf16s_to_utf8s(
    > + (wchar_t *)
    > + in_msg->body.kvp_set.data.value,
    > + in_msg->body.kvp_set.data.value_size,
    > + UTF16_LITTLE_ENDIAN,
    > + message->body.kvp_set.data.value,
    > + HV_KVP_EXCHANGE_MAX_VALUE_SIZE) + 1;
    > + break;
    > +

    This block of unreadable text is so nasty.

    You could return directly if the msg = kmalloc() fails and pull
    everything in one indent level. It's normally more readable to
    handle errors as soon as possible anyway.

    Probably that's not enough to make a difference and we'd need to
    introduce a new function.

    Btw I don't know if utf16s_to_utf8s() counts the NUL char or not.
    It feels like maybe we could end up with ->value_size equal to
    HV_KVP_EXCHANGE_MAX_VALUE_SIZE + 1.

    regards,
    dan carpenter
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-03-11 11:43    [W:0.022 / U:0.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site