lkml.org 
[lkml]   [2012]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 18/37] PCI: Use list_for_each_entry_safe instead of list_for_each_safe
    Date
    So could skip using pci_dev_b().

    Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
    Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    ---
    drivers/pci/remove.c | 12 +++++-------
    1 files changed, 5 insertions(+), 7 deletions(-)

    diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
    index 62c348c..d4fdf7b 100644
    --- a/drivers/pci/remove.c
    +++ b/drivers/pci/remove.c
    @@ -113,15 +113,15 @@ void pci_stop_and_remove_bus_device(struct pci_dev *dev)

    static void __pci_remove_bus_devices(struct pci_bus *bus)
    {
    - struct list_head *l, *n;
    + struct pci_dev *dev, *tmp;

    - list_for_each_safe(l, n, &bus->devices)
    - __pci_remove_bus_device(pci_dev_b(l));
    + list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list)
    + __pci_remove_bus_device(dev);
    }

    static void pci_stop_bus_devices(struct pci_bus *bus)
    {
    - struct list_head *l, *n;
    + struct pci_dev *dev, *tmp;

    /*
    * VFs could be removed by pci_stop_and_remove_bus_device() in the
    @@ -131,10 +131,8 @@ static void pci_stop_bus_devices(struct pci_bus *bus)
    * We can iterate the list backwards to get prev valid PF instead
    * of removed VF.
    */
    - list_for_each_prev_safe(l, n, &bus->devices) {
    - struct pci_dev *dev = pci_dev_b(l);
    + list_for_each_entry_safe_reverse(dev, tmp, &bus->devices, bus_list)
    pci_stop_bus_device(dev);
    - }
    }

    /**
    --
    1.7.7


    \
     
     \ /
      Last update: 2012-03-10 08:11    [W:0.022 / U:0.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site