lkml.org 
[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/6] Remove tty_lock from the console drivers
Date
On Thursday 01 March 2012, Alan Cox wrote:
>
> This needs a fair bit of testing and a bit of review wouldn't go amiss, but
> it does drive the tty_lock() mess out of the console and correct chunks of
> console locking in the process.

I've spent an hour looking at the patches and trying to understand the code
paths you touch. The use of console_lock for more stuff than it's currently
used for is slightly worrying, mostly because it's still an old-style
semaphore and not covered by lockdep because of that, which might make testing
harder, but it also seems to be the logical thing to do as you write.

Other than that and the VT_WAITEVENT issue that Jiri pointed out, nothing
else caught my eye, it all looks good.

Arnd


\
 
 \ /
  Last update: 2012-03-01 23:13    [from the cache]
©2003-2011 Jasper Spaans