lkml.org 
[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/6] vt: push down the tty lock so we can see what is left to tackle
Date
On Thursday 01 March 2012, Alan Cox wrote:
> @@ -1407,6 +1425,7 @@ int vt_move_to_console(unsigned int vt, int alloc)
> return -EIO;
> }
> console_unlock();
> + /* Review: I don't see why we need tty_lock here FIXME */
> tty_lock();
> if (vt_waitactive(vt + 1)) {
> pr_debug("Suspend: Can't switch VCs.");

I'm pretty sure I only added this in be1bc288 "tty: introduce
wait_event_interruptible_tty" so I could release the mutex again in
vt_event_wait.

All other callers of that function hold it, so it needs to be released
in vt_event_wait and that can only be done if it's known to be held first.

Arnd


\
 
 \ /
  Last update: 2012-03-01 22:55    [W:0.049 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site