Messages in this thread |  | | | Date | Thu, 01 Mar 2012 13:02:47 -0800 | | From | "H. Peter Anvin" <> | | Subject | Re: [tip:x86/asm] bitops: Optimise get_order() |
| |
David, could you make a fix for this?
-hpa
On 02/29/2012 04:31 PM, Stephen Rothwell wrote: > On Wed, 29 Feb 2012 15:29:04 -0500 Paul Gortmaker<paul.gortmaker@windriver.com> wrote: >> >> On Mon, Feb 20, 2012 at 6:20 PM, tip-bot for David Howells >> <dhowells@redhat.com> wrote: >>> Commit-ID: d66acc39c7cee323733c8503b9de1821a56dff7e >>> Gitweb: http://git.kernel.org/tip/d66acc39c7cee323733c8503b9de1821a56dff7e >>> Author: David Howells<dhowells@redhat.com> >>> AuthorDate: Mon, 20 Feb 2012 22:39:29 +0000 >>> Committer: H. Peter Anvin<hpa@zytor.com> >>> CommitDate: Mon, 20 Feb 2012 14:47:02 -0800 >>> >>> bitops: Optimise get_order() >> >> This is causing build failures on non-x86 in linux next according to git bisect. > > Presumably it needs to include linux/bitops.h (and see below). > >>> +static inline __attribute_const__ >>> +int __get_order(unsigned long size) >>> +{ >>> + int order; >>> + >>> + size--; >>> + size>>= PAGE_SHIFT; >>> +#if BITS_PER_LONG == 32 >>> + order = fls(size); >>> +#else >>> + order = fls64(size); >>> +#endif > > linux/bitops.h has fls_long() that does this size test and calls the right thing. >
|  |