lkml.org 
[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/6] vt: push down the tty lock so we can see what is left to tackle
    On 03/01/2012 08:50 PM, Alan Cox wrote:
    > --- a/drivers/tty/vt/vt_ioctl.c
    > +++ b/drivers/tty/vt/vt_ioctl.c
    > @@ -281,7 +281,6 @@ int vt_ioctl(struct tty_struct *tty,
    >
    > console = vc->vc_num;
    >
    > - tty_lock();

    Note that this breaks bisection. Further in vt_ioctl, there is a call to
    vt_event_wait_ioctl which calls vt_event_wait and that calls
    wait_event_interruptible_tty which unlocks BTM.

    You change wait_event_interruptible_tty to wait_event_interruptible even
    in 4/6.

    The VT_WAITEVENT case should have tty_lock until 4/6 (and not longer).

    thanks,
    --
    js
    suse labs


    \
     
     \ /
      Last update: 2012-03-01 21:33    [W:0.025 / U:2.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site