Messages in this thread | | | Date | Thu, 1 Mar 2012 11:42:01 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 5/9] writeback: introduce the pageout work |
| |
On Thu, 1 Mar 2012 12:04:04 +0100 Jan Kara <jack@suse.cz> wrote:
> > iirc, the way I "grabbed" the page was to actually lock it, with > > [try_]_lock_page(). And unlock it again way over within the writeback > > thread. I forget why I did it this way, rather than get_page() or > > whatever. Locking the page is a good way of preventing anyone else > > from futzing with it. It also pins the inode, which perhaps meant that > > with careful management, I could avoid the igrab()/iput() horrors > > discussed above. > > I think using get_page() might be a good way to go.
get_page() doesn't pin the inode - truncate() will still detach it from the address_space().
| |