Messages in this thread |  | | | Date | Thu, 1 Mar 2012 07:25:37 -0500 | | From | Jeff Layton <> | | Subject | Re: [PATCH 4/9] cifs: Push file_update_time() into cifs_page_mkwrite() |
| |
On Thu, 1 Mar 2012 12:41:38 +0100 Jan Kara <jack@suse.cz> wrote:
> CC: Steve French <sfrench@samba.org> > CC: linux-cifs@vger.kernel.org > Signed-off-by: Jan Kara <jack@suse.cz> > --- > fs/cifs/file.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/fs/cifs/file.c b/fs/cifs/file.c > index 4dd9283..8e3b23b 100644 > --- a/fs/cifs/file.c > +++ b/fs/cifs/file.c > @@ -2425,6 +2425,9 @@ cifs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) > { > struct page *page = vmf->page; > > + /* Update file times before taking page lock */ > + file_update_time(vma->vm_file); > + > lock_page(page); > return VM_FAULT_LOCKED; > }
Sorry, I meant to comment on this earlier...
I think we can probably drop this patch. cifs doesn't currently set S_NOCMTIME on all inodes (only when MS_NOATIME is set currently), but I think that it probably should. Timestamps should be the purview of the server.
-- Jeff Layton <jlayton@redhat.com>
|  |