Messages in this thread | | | Date | Thu, 9 Feb 2012 08:53:57 +0100 | From | Ingo Molnar <> | Subject | Re: Re: [PATCH v10 3.3-rc2 1/9] uprobes: Install and remove breakpoints. |
| |
* Srikar Dronamraju <srikar@linux.vnet.ibm.com> wrote:
> /* Clear REX.b bit (extension of MODRM.rm field): > * we want to encode rax/rcx, not r8/r9. > */
Small stylistic nit, just saw this chunk fly by - the proper comment style is like this one:
> /* > * Point cursor at the modrm byte. The next 4 bytes are the > * displacement. Beyond the displacement, for some instructions, > * is the immediate operand. > */
Thanks,
Ingo
| |