lkml.org 
[lkml]   [2012]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support
    On Sun, Feb 05, 2012 at 01:14:52AM +0100, Richard Weinberger wrote:
    > This patch introduces NETFILTER_XT_TARGET_LOG_RING.
    > It allows logging into various ring buffers which are
    > represented as pipe-like files in /proc/net/netfilter/xt_LOG_ring/.
    >
    > Signed-off-by: Richard Weinberger <richard@nod.at>
    > ---
    > include/linux/netfilter/xt_LOG.h | 13 +-
    > include/net/netfilter/nf_log.h | 1 +
    > include/net/netfilter/xt_log_ring.h | 24 +
    > net/netfilter/Kconfig | 13 +
    > net/netfilter/Makefile | 2 +
    > net/netfilter/xt_LOG.c | 921 -----------------------------
    > net/netfilter/xt_LOG_core.c | 1108 +++++++++++++++++++++++++++++++++++
    > net/netfilter/xt_LOG_ring.c | 430 ++++++++++++++

    Can you avoid this rename and splitting LOG into two files? I prefer
    having everything into the same file xt_LOG.c.

    Apart from that, this looks fine to me.


    \
     
     \ /
      Last update: 2012-02-08 11:31    [W:0.020 / U:30.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site