lkml.org 
[lkml]   [2012]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cdrom: move shared static to cdrom_device_info
On 02/08/2012 06:32 PM, Paolo Bonzini wrote:
> The keeplocked variable in the cdrom driver is shared across multiple
> drives, but set in per-device ioctls. Move it to the per-device struct,
> avoiding that the setting on one drive affects the driver's behavior
> when closing another.
>
> [ Impact: limit udev's confusion to one drive when a CD burning program
> unlocks the CD door at the end of burning. ]
>
> Cc: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Would this be acceptable for 3.3?

Yeah, looks simple enough. I thought we had a module parameter for this
too, but we do not. So I've applied it for 3.3.

--
Jens Axboe



\
 
 \ /
  Last update: 2012-02-08 20:09    [W:0.155 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site