Messages in this thread | | | Date | Wed, 08 Feb 2012 20:05:02 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH] cdrom: move shared static to cdrom_device_info |
| |
On 02/08/2012 06:32 PM, Paolo Bonzini wrote: > The keeplocked variable in the cdrom driver is shared across multiple > drives, but set in per-device ioctls. Move it to the per-device struct, > avoiding that the setting on one drive affects the driver's behavior > when closing another. > > [ Impact: limit udev's confusion to one drive when a CD burning program > unlocks the CD door at the end of burning. ] > > Cc: Jens Axboe <axboe@kernel.dk> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > Would this be acceptable for 3.3?
Yeah, looks simple enough. I thought we had a module parameter for this too, but we do not. So I've applied it for 3.3.
-- Jens Axboe
| |