lkml.org 
[lkml]   [2012]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch]block: fix ioc locking warning
Date
On 02/05/2012 11:50 PM, Shaohua Li wrote:

> diff --git a/block/blk-ioc.c b/block/blk-ioc.c
> index 27a06e0..7490b6d 100644
> --- a/block/blk-ioc.c
> +++ b/block/blk-ioc.c
> @@ -204,7 +204,9 @@ void put_io_context(struct io_context *ioc, struct request_queue *locked_q)
> spin_unlock(last_q->queue_lock);
> last_q = NULL;
>
> - if (!spin_trylock(this_q->queue_lock))
> + /* spin_trylock() always successes in UP case */
> + if (this_q != locked_q&&
> + !spin_trylock(this_q->queue_lock))
> break;
> last_q = this_q;
> continue;

I can see from the rest of this thread that your patch fixes a multitude
of different backtraces, including (most importantly :) mine, thanks:

http://marc.info/?l=linux-kernel&m=132804761925018&w=2





\
 
 \ /
  Last update: 2012-02-08 19:09    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site