lkml.org 
[lkml]   [2012]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] SCSI, st: modify tape driver to allow writing immediate filemarks
    From
    Date
    On Tue, 2012-02-07 at 17:07 -0800, Lee Duncan wrote:
    > Add an st module option st_nowait_eof which defaults to 0. Setting this
    > option to 1 tells the st driver not to wait when writing a filemark, which
    > can result in much faster times on streaming tape drives.

    trivial comments:

    > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
    []
    > @@ -81,6 +81,7 @@ static int max_sg_segs;
    > static int try_direct_io = TRY_DIRECT_IO;
    > static int try_rdio = 1;
    > static int try_wdio = 1;
    > +static int st_nowait_eof = 0;

    Could be bool.

    > @@ -1106,6 +1109,11 @@ static int check_tape(struct scsi_tape *STp, struct file *filp)
    > STp->drv_buffer));
    > }
    > STp->drv_write_prot = ((STp->buffer)->b_data[2] & 0x80) != 0;
    > + if (!STp->drv_buffer && STp->immediate_filemark) {
    > + printk(KERN_WARNING "%s: non-buffered tape: "
    > + "disabling writing immediate filemarks", name);

    Needs terminating "\n" and it's better to coalesce the
    format and ignore 80 char lines to make arbitrary greps
    a bit easier.

    > diff --git a/drivers/scsi/st.h b/drivers/scsi/st.h
    []
    > @@ -120,6 +120,7 @@ struct scsi_tape {
    > unsigned char c_algo; /* compression algorithm */
    > unsigned char pos_unknown; /* after reset position unknown */
    > unsigned char sili; /* use SILI when reading in variable b mode */
    > + unsigned char immediate_filemark; /* set immediate bit when writing filemark */

    could be bool




    \
     
     \ /
      Last update: 2012-02-08 02:19    [W:0.020 / U:149.324 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site