Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 7 Feb 2012 08:33:15 -0800 | Subject | Re: [PATCH] block: strip out locking optimization in put_io_context() |
| |
On Tue, Feb 7, 2012 at 8:28 AM, Jens Axboe <axboe@kernel.dk> wrote: > > That was already merged in my tree. I don't see how it makes much > difference in tracking the regression. You said that removing it made no > difference for the find test case, so I'd be more comfortable getting > rid of the nasty optimization.
Yeah, please just get rid of the crazy code. Maybe *that* fixes the regression too, who knows?
For all we know, the "fast case" is what causes extra locking only to then fail and not even be a fast-path.
I think our default action should always be to simplify and clean up code, unless you have seriously hard numbers to show that the code complexity is worth it.
Linus
| |