Messages in this thread | | | Date | Tue, 7 Feb 2012 13:21:44 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v5 11/18] perf: add code to support PERF_SAMPLE_BRANCH_STACK |
| |
Em Tue, Feb 07, 2012 at 03:11:56PM +0100, Stephane Eranian escreveu: > On Mon, Feb 6, 2012 at 7:06 PM, Arnaldo Carvalho de Melo <acme@redhat.com> wrote: > >> +++ b/tools/perf/util/annotate.c > >> @@ -64,7 +64,7 @@ int symbol__inc_addr_samples(struct symbol *sym, struct map *map,
> >> pr_debug3("%s: addr=%#" PRIx64 "\n", __func__, map->unmap_ip(map, addr));
> >> - if (addr >= sym->end) > >> + if (addr >= sym->end || addr < sym->start)
> > This is not related to this, would be better to come in a separate patch > > with a proper explanation.
> You mean in this patchset or separately?
Either way it would be standalone, I'd pick it, but please write a commit message explaining why it is needed.
Multiple people submitted this already but without a good commit message which I think may be papering over a bug.
- Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |