Messages in this thread | | | Subject | Re: [PATCH 1/2] dmaengine: intel_mid_dma: fix error status mask | From | Vinod Koul <> | Date | Mon, 06 Feb 2012 17:09:52 +0530 |
| |
On Tue, 2012-01-31 at 12:48 +0200, Adrian Hunter wrote: > The error status mask (MASK_ERR) has the same format as the other > masks (MASK_TFR, MASK_BLOCK etc) and must be cleared the same way. > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/dma/intel_mid_dma.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/intel_mid_dma.c b/drivers/dma/intel_mid_dma.c > index 74f70aa..512e2ab 100644 > --- a/drivers/dma/intel_mid_dma.c > +++ b/drivers/dma/intel_mid_dma.c > @@ -1056,7 +1056,8 @@ static irqreturn_t intel_mid_dma_interrupt(int irq, void *data) > } > err_status &= mid->intr_mask; > if (err_status) { > - iowrite32(MASK_INTR_REG(err_status), mid->dma_base + MASK_ERR); > + iowrite32((err_status << INT_MASK_WE), > + mid->dma_base + MASK_ERR); why not use the macro? > call_tasklet = 1; > } > if (call_tasklet)
-- ~Vinod
| |