lkml.org 
[lkml]   [2012]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] killing boilerplate checks in ->link/->mkdir/->rename
    On Fri, Feb 03, 2012 at 01:16:12AM +0000, Al Viro wrote:
    > On Thu, Feb 02, 2012 at 03:46:06PM -0800, Linus Torvalds wrote:
    > > On Thu, Feb 2, 2012 at 1:24 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
    > * WTF is XFS doing with these checks?

    It is validating nlink against the maximum supported by the XFS
    on-disk format. It was originally limited by what could be reported
    to pathconf() on Irix - a signed int. We have that same problem on
    Linux, too, because on 32 bit systems the maximum number of links
    that can be reported via pathconf is 2^31....

    > Note that we have them
    > done _twice_ on all paths - explictly from xfs_create(), xfs_link(),
    > xfs_rename() and then from xfs_bumplink() called by exactly the same
    > set of functions.

    Well, that's a bit stupid, isn't it? Trivial to fix, though...

    Cheers,

    Dave.
    --
    Dave Chinner
    david@fromorbit.com


    \
     
     \ /
      Last update: 2012-02-06 23:51    [W:5.357 / U:0.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site