Messages in this thread | | | Date | Tue, 07 Feb 2012 08:47:11 +1100 | From | Ryan Mallon <> | Subject | Re: [PATCH 1/3] apple_bl: Convert printks to pr_<level> |
| |
On 07/02/12 01:35, Seth Forshee wrote:
> On Mon, Feb 06, 2012 at 10:23:13AM +1100, Ryan Mallon wrote: >> On 04/02/12 07:28, Seth Forshee wrote: >> >>> Signed-off-by: Seth Forshee <seth.forshee@canonical.com> >>> --- >>> drivers/video/backlight/apple_bl.c | 29 ++++++++--------------------- >>> 1 files changed, 8 insertions(+), 21 deletions(-) >>> >>> diff --git a/drivers/video/backlight/apple_bl.c b/drivers/video/backlight/apple_bl.c >>> index be98d15..66d5bec 100644 >>> --- a/drivers/video/backlight/apple_bl.c >>> +++ b/drivers/video/backlight/apple_bl.c >>> @@ -16,6 +16,8 @@ >>> * get at the firmware code in order to figure out what it's actually doing. >>> */ >>> >>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >>> + >>> #include <linux/module.h> >>> #include <linux/kernel.h> >>> #include <linux/init.h> >>> @@ -38,13 +40,6 @@ struct hw_data { >>> >>> static const struct hw_data *hw_data; >>> >>> -#define DRIVER "apple_backlight: " >>> - >>> -/* Module parameters. */ >>> -static int debug; >>> -module_param_named(debug, debug, int, 0644); >>> -MODULE_PARM_DESC(debug, "Set to one to enable debugging messages."); >> >> >> Removal of this module parameter is not noted in the changelog. >> >>> - >>> /* >>> * Implementation for machines with Intel chipset. >>> */ >>> @@ -58,9 +53,7 @@ static int intel_chipset_send_intensity(struct backlight_device *bd) >>> { >>> int intensity = bd->props.brightness; >>> >>> - if (debug) >>> - printk(KERN_DEBUG DRIVER "setting brightness to %d\n", >>> - intensity); >>> + pr_debug("setting brightness to %d\n", intensity); >> >> >> As Joe points out, this no longer has the same behaviour as it did >> previously. The pr_debug will only show up if you have DEBUG defined. >> Again, this should probably be mentioned in the changelog. > > I doesn't matter to me one way or the other whether these statements are > enabled by module parameter, I was just thinking that pr_debug was > generally preferred. I can put the module parameter back or denote this > in the changelog, whichever is more acceptable.
Actually, you can just remove the debug print. The backlight core has a similar message already, so no need to duplicate it here. Note this reasoning in the changelog though.
~Ryan
| |