lkml.org 
[lkml]   [2012]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 2/5] netdev: ethernet dev_alloc_skb to netdev_alloc_skb
From
From: "Pradeep A. Dalvi" <netdev@pradeepdalvi.com>
Date: Sun, 5 Feb 2012 18:20:10 +0530

> From: Pradeep A Dalvi <netdev@pradeepdalvi.com>
>
> Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet
> - Removed extra skb->dev = dev after netdev_alloc_skb
>
> Signed-off-by: Pradeep A Dalvi <netdev@pradeepdalvi.com>

Applied, but again I had to fix things:

> - p = dev_alloc_skb(IEEE802_3_SZ + DE4X5_ALIGN + 2);
> + p = netdev_alloc_skb(dev, IEEE802_3_SZ + DE4X5_ALIGN + 2);
...
> - p = dev_alloc_skb(len + 2);
> + p = netdev_alloc_skb(dev, len + 2);

Leave existing indentation alone.

> - skb = dev_alloc_skb(ugeth->ug_info->uf_info.max_rx_buf_length +
> - UCC_GETH_RX_DATA_BUF_ALIGNMENT);
> + skb = netdev_alloc_skb(ugeth->ndev,
> + ugeth->ug_info->uf_info.max_rx_buf_length +
> + UCC_GETH_RX_DATA_BUF_ALIGNMENT);

Line up subsequent lines of a multiline series of function arguments
properly, each should start at the first column after the function calls
openning parenthesis.


\
 
 \ /
  Last update: 2012-02-06 17:51    [from the cache]
©2003-2011 Jasper Spaans