lkml.org 
[lkml]   [2012]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH, v2] checkpatch: Warn on code with 6+ tab indentation, remove 80col warning

* Joe Perches <joe@perches.com> wrote:

> On Sun, 2012-02-05 at 12:38 +0100, Ingo Molnar wrote:
> >
> > In practice patch submitters take warnings just as
> > seriously.
>
> In practice, that's not necessarily bad.

In practice it *is* bad, and I say that as a maintainer who is
receiving many checkpatch 'fixes' on a daily basis. Many
checkpatch warnings are legitimate - but the col80 one is bogus
in many cases.

Bogus warnings pollute the output of the tool, reducing the
utility of the *other* warnings.

( GCC frequently made this mistake in the past, emitting dubious
warnings by default - it's been getting somewhat better
lately. )

So if your patch emits no warning for the col80 thing then
that's a step forward in the right direction in my opinion.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-02-05 19:17    [W:0.096 / U:1.220 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site