Messages in this thread | | | Subject | Re: [PATCH, v2] checkpatch: Warn on code with 6+ tab indentation, remove 80col warning | From | Joe Perches <> | Date | Sun, 05 Feb 2012 08:21:25 -0800 |
| |
On Sun, 2012-02-05 at 12:38 +0100, Ingo Molnar wrote: > In practice patch submitters take warnings just as seriously.
In practice, that's not necessarily bad. I do think there should be some line length limit. 80 might be a bit short.
> If it is emitted by the default checkpatch run, it's acted > upon. That is the human behavior that is a given.
Look at some of the lines in drivers/staging that have _really_ long lines that would not get any warning if this were removed.
$ git ls-files "drivers/staging/*.[ch]" | xargs cat | \ awk '{print length($0),$0}' | sort -rn | head -50
gotta love the first few...
A few lines in arch/x86 might benefit from some wrapping too.
| |