[lkml]   [2012]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH, v2] checkpatch: Warn on code with 6+ tab indentation, remove 80col warning
    On Sun, 2012-02-05 at 12:38 +0100, Ingo Molnar wrote:
    > In practice patch submitters take warnings just as seriously.

    In practice, that's not necessarily bad.
    I do think there should be some line length limit.
    80 might be a bit short.

    > If it is emitted by the default checkpatch run, it's acted
    > upon. That is the human behavior that is a given.

    Look at some of the lines in drivers/staging
    that have _really_ long lines that would not
    get any warning if this were removed.

    $ git ls-files "drivers/staging/*.[ch]" | xargs cat | \
    awk '{print length($0),$0}' | sort -rn | head -50

    gotta love the first few...

    A few lines in arch/x86 might benefit from
    some wrapping too.

     \ /
      Last update: 2012-02-05 17:25    [W:0.024 / U:2.260 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site