Messages in this thread | | | From | Linus Torvalds <> | Date | Sat, 4 Feb 2012 07:16:51 -0800 | Subject | Re: cgroup_release_agent() with call_usermodehelper() with UMH_WAIT_EXEC may crash |
| |
On Sat, Feb 4, 2012 at 2:03 AM, Heiko Carstens <heiko.carstens@de.ibm.com> wrote: > > Something like the patch below? Still boots...
Yes, except that if we touch the comm copying code, let's do what Oleg suggested and make it a helper function to create the "comm[]" data array instead of open-coding it and adding new random local variables to prepare_binprm().
But looks good otherwise. I'm a *bit* nervous that some prepare_binprm() caller hasn't set up bprm->filename that early yet, though. It seems like we expect that to be set up by the caller, which seems a bit odd, actually.
Linus
| |